https://sherlock-files.ams3.digitaloceanspaces.com/profile_images/defaults/default_avatar_6.png

PP1004

Security Researcher

Contact Me

High

4

Total

Medium

7

Total

$2.23K

Total Earnings

#1054 All Time

1x

Payouts

regular

1x

Top 10

regular

1x

Top 25

regular

1x

Top 50

All

Code4rena

May '22

Rubicon contest

Rubicon contest

2,233.61 USDC • 11 total findings • Code4rena • PP1004

#6

high

RubiconRouter _swap does not pass whole amount to RubiconMarket

high

BathToken LPs Unable To Receive Bonus Token Due To Lack Of Wallet Setter Method

high

Attacker Could Steal Almost All The Bonus Token In BathBuddy Vesting Wallet

high

First depositor can break minting of shares

medium

Inconsistent Order Book Accounting When Working With Transfer-On-Fee or Deflationary Tokens

medium

Cannot deposit to BathToken if token is Deflationary Token (BathHouse.sol)

medium

previewWithdraw calculates shares wrongly

medium

maxSellAllAmount and maxBuyAllAmount functions can be unintentionally paused (always revert).

medium

Use `safeTransfer()`/`safeTransferFrom()` instead of `transfer()`/`transferFrom()`

medium

RubiconRouter maxSellAllAmount does not trasnfer user's fund into its address, causing calls to always revert

medium

Use `call()` instead of `transfer()` when transferring ETH in RubiconRouter